Skip to content

docs: Add {mdExpandTabs} where code snippet tabs differ#17909

Merged
s1gr1d merged 9 commits into
masterfrom
sig/add-tab-include
Jun 2, 2026
Merged

docs: Add {mdExpandTabs} where code snippet tabs differ#17909
s1gr1d merged 9 commits into
masterfrom
sig/add-tab-include

Conversation

@s1gr1d

@s1gr1d s1gr1d commented May 28, 2026

Copy link
Copy Markdown
Member

DESCRIBE YOUR PR

⚠️ Needs this for CI to not fail anymore: #17941

By default, only the first code snippet is included in the generated .md. This PR adds {mdExpandTabs} to snippets, where each tab is relevant for the LLM context.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel

vercel Bot commented May 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Jun 2, 2026 10:13am
sentry-docs Ready Ready Preview, Comment Jun 2, 2026 10:13am

Request Review

@s1gr1d s1gr1d requested a review from philprime May 28, 2026 13:57
@codeowner-assignment codeowner-assignment Bot requested review from a team and ryan953 May 28, 2026 13:57
@s1gr1d s1gr1d requested a review from sergical May 28, 2026 14:01

@sergical sergical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot checked a bunch and for some reason it correctly picked up https://sentry-docs-git-sig-add-tab-include.sentry.dev/platforms/javascript/guides/nextjs/manual-setup/#initialize-sentry-sdks but did not pick up https://sentry-docs-git-sig-add-tab-include.sentry.dev/platforms/javascript/guides/nextjs/#sdk-initialization

maybe worth tweaking the skill a bit, idk if there's evals that this can run against but definitely should have more solid examples of what to do vs what not to do

Enable this feature by setting the `enableMetricKit` option to `true`:


```swift {tabTitle:Swift}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if these are different enough to warrant mdExpandTabs

Base automatically changed from sig/copy-page-all-snippets-conditional to master May 29, 2026 09:41
s1gr1d added 2 commits May 29, 2026 13:47
# Conflicts:
#	.claude/skills/technical-docs/SKILL.md
#	includes/react-native-react-navigation-setup.mdx
@antonis antonis self-requested a review June 2, 2026 08:54
s1gr1d added a commit that referenced this pull request Jun 2, 2026
## DESCRIBE YOUR PR
CI in this PR fails because of broken links. I updated the links.
- #17909

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [ ] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
@codeowner-assignment codeowner-assignment Bot requested review from a team June 2, 2026 10:01
@s1gr1d s1gr1d merged commit fa2ff0e into master Jun 2, 2026
20 checks passed
@s1gr1d s1gr1d deleted the sig/add-tab-include branch June 2, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants