feat(minidump): Guard against compressed minidump streams

[tobias-wilfert]

Adds a check to ensure we are not streaming compressed minidumps to objectstore (since neither it not symbolicator can currently handle them).

FIX INGEST-891

[linear-code]

INGEST-891

[tobias-wilfert]

Add this to ensure that compressed attachment still work.

[tobias-wilfert]

We also reject the item here if we just fail to read for the stream for any reason, but I think that is ok.

[jjbayer]

This is pretty elegant!

[jjbayer]

nit: You could put this in a helper function get_compression(data: &[u8]) -> Option<HttpEncoding> and share the helper with decoder_from.

[tobias-wilfert]

Not sure we can use it in decoder_from since that logic is slightly more sophisticated:

relay/relay-server/src/endpoints/minidump.rs

Lines 143 to 162 in 0f95e1e

	/// Creates a decoder based on the magic bytes the minidump payload
	fn decoder_from(minidump_data: Bytes) -> Option<Box<dyn Read>> {
	if minidump_data.starts_with(GZIP_MAGIC_HEADER) {
	return Some(Box::new(GzDecoder::new(Cursor::new(minidump_data))));
	} else if minidump_data.starts_with(XZ_MAGIC_HEADER) {
	return Some(Box::new(XzDecoder::new(Cursor::new(minidump_data))));
	} else if minidump_data.starts_with(BZIP2_MAGIC_HEADER) {
	return Some(Box::new(BzDecoder::new(Cursor::new(minidump_data))));
	} else if minidump_data.starts_with(ZSTD_MAGIC_HEADER) {
	return match ZstdDecoder::new(Cursor::new(minidump_data)) {
	Ok(decoder) => Some(Box::new(decoder)),
	Err(ref err) => {
	relay_log::error!(error = err as &dyn Error, "failed to create ZstdDecoder");
	None
	}
	};
	}
	None
	}

[jjbayer]

My thinking was something like

fn decoder_from(minidump_data: Bytes) -> Option<Box<dyn Read>> {
    match get_compression(minidump_data) {
        HttpEncoding::Gzip => Some(Box::new(GzDecoder::new(Cursor::new(minidump_data))))

[jjbayer]

Discussed offline, we're hesitant to add uncommon variants to the HttpEncoding enum so this would require a separate enum -> not worth the effort.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit dcbb783. Configure here.}

[jjbayer]

Discussed offline, we're hesitant to add uncommon variants to the HttpEncoding enum so this would require a separate enum -> not worth the effort.