Skip to content

Consolidate config, openapi, and asyncapi logic#2371

Closed
webb-ben wants to merge 3 commits into
geopython:masterfrom
webb-ben:openapi-safe
Closed

Consolidate config, openapi, and asyncapi logic#2371
webb-ben wants to merge 3 commits into
geopython:masterfrom
webb-ben:openapi-safe

Conversation

@webb-ben

Copy link
Copy Markdown
Member

Overview

Organize the implementations of pygeoapi.config, pygeoapi.openapi, pygeoapi.asyncapi with each other. Each implements the methods (where X is the case sensitive name of the module):

  • get_x: Read and serialize the document
  • get_x_schema: Read and serialize the schema document
  • validate_x_document: Validate document against schema

Furthermore some alignment was done on the CLI options for these functions.

  • Each now falls back to the respective PYGEOAPI_X environment variable if an override is not provided during execution.
  • Deprecate --output-file in favor of feature specific flag.
  • Derive format from output file type. Only recognize --format when no file to write.

TODO: Add AsyncAPI tests

Related Issue / discussion

Additional information

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant