Fix a crash when removing layouts and layout options#58
Merged
matcool merged 3 commits intogeode-sdk:mainfrom May 30, 2025
Merged
Fix a crash when removing layouts and layout options#58matcool merged 3 commits intogeode-sdk:mainfrom
matcool merged 3 commits intogeode-sdk:mainfrom
Conversation
Member
|
Welcome back johnny cena (you changed the indentation of the whole file) |
Member
|
actually not the file but the relevant code since you put it in a lambda, didn't see it initially because of the mess of a diff this all really shouldn't be in one massive function but it's not your fault |
Contributor
Author
|
Yeah, wanted to get a fix out first. I could refactor it all if needed to be separate methods for separate attributes |
dankmeme01
approved these changes
May 9, 2025
Kingminer7
pushed a commit
to Kingminer7/DevTools
that referenced
this pull request
Aug 6, 2025
* Fix a crash when removing layouts and layout opts * Clean up code * Move everything into methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff is very confused but I just added like 6 lines