test(ethexe-network): append start_paused to peer_score smoke test#5368
test(ethexe-network): append start_paused to peer_score smoke test#5368grishasobol merged 4 commits intomasterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the configuration of a specific smoke test to ensure it starts in a paused state. This change is intended to improve test stability and reliability by controlling the execution environment of the asynchronous test. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the smoke test in ethexe/network/src/peer_score.rs to start the Tokio runtime in a paused state (start_paused = true). This change typically allows for deterministic time-based testing. I have no feedback to provide.
|
@claude fix, change sleep to advance in the test |
|
Claude finished @grishasobol's task in 42s —— View job Tasks
Changed |
Co-authored-by: Gregory Sobol <grishasobol@users.noreply.github.com>
https://github.com/gear-tech/gear/actions/runs/24716787720/job/72296361617