Skip to content

test(ethexe-network): append start_paused to peer_score smoke test#5368

Merged
grishasobol merged 4 commits intomasterfrom
gsobol/ethexe/peer-score-smoke
Apr 22, 2026
Merged

test(ethexe-network): append start_paused to peer_score smoke test#5368
grishasobol merged 4 commits intomasterfrom
gsobol/ethexe/peer-score-smoke

Conversation

@grishasobol
Copy link
Copy Markdown
Member

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 21, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  ethexe/network/src/peer_score.rs  0% smaller

@grishasobol grishasobol requested a review from ark0f April 21, 2026 11:43
@grishasobol grishasobol self-assigned this Apr 21, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the configuration of a specific smoke test to ensure it starts in a paused state. This change is intended to improve test stability and reliability by controlling the execution environment of the asynchronous test.

Highlights

  • Test Configuration Update: Updated the smoke test in peer_score.rs to use the start_paused = true configuration for the tokio test attribute.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@grishasobol grishasobol added the A0-pleasereview PR is ready to be reviewed by the team label Apr 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the smoke test in ethexe/network/src/peer_score.rs to start the Tokio runtime in a paused state (start_paused = true). This change typically allows for deterministic time-based testing. I have no feedback to provide.

@grishasobol
Copy link
Copy Markdown
Member Author

@claude fix, change sleep to advance in the test

@claude
Copy link
Copy Markdown

claude Bot commented Apr 21, 2026

Claude finished @grishasobol's task in 42s —— View job


Tasks

  • Read the peer_score.rs file
  • Find sleep usage and replace with tokio::time::advance
  • Commit and push changes

Changed time::sleep(alice_config.driver_time).awaittime::advance(alice_config.driver_time).await in the smoke test (line 440). With start_paused = true, tokio's time is frozen and sleep never completes — advance explicitly moves the mock clock forward, matching the pattern already used in the peer_forgot test.

Co-authored-by: Gregory Sobol <grishasobol@users.noreply.github.com>
@grishasobol grishasobol enabled auto-merge April 21, 2026 16:26
@grishasobol grishasobol added this pull request to the merge queue Apr 22, 2026
Merged via the queue into master with commit 8039df7 Apr 22, 2026
59 of 63 checks passed
@grishasobol grishasobol deleted the gsobol/ethexe/peer-score-smoke branch April 22, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0-pleasereview PR is ready to be reviewed by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants