feat(vara-eth-idea/frontend): smooth pagination#2449
Open
vraja-nayaka wants to merge 3 commits intomainfrom
Open
feat(vara-eth-idea/frontend): smooth pagination#2449vraja-nayaka wants to merge 3 commits intomainfrom
vraja-nayaka wants to merge 3 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the table and pagination systems to support smoother view transitions and advanced caching, introducing the useTablePagination and usePaginationEffects hooks. It also migrates the activity panel state to a global atom and adopts queryOptions for better React Query integration. Feedback focuses on conditionally rendering sort icons for non-sortable columns, parameterizing page sizes in hooks for better reusability, ensuring page size multiples for correct placeholder mapping, and refining data slicing in the pagination utility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.