feat(apis/vara-eth): support permit, requestCodeValidationOnBehalf#2446
Draft
osipov-mit wants to merge 1 commit intomainfrom
Draft
feat(apis/vara-eth): support permit, requestCodeValidationOnBehalf#2446osipov-mit wants to merge 1 commit intomainfrom
osipov-mit wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Ethereum contract clients by introducing a modular base architecture and reorganizing files into a dedicated contracts directory. It updates the ABIs for the Mirror, Router, and WrappedVara contracts and adds support for EIP-712 typed data signing, EIP-4844 blob transactions for code validation, and permit-based interactions. Feedback was provided regarding an unimplemented method in the Mirror client that should be addressed before release.
Comment on lines
+250
to
+253
| executableBalanceTopUpWithPermit(_value: bigint, _deadline: bigint, _v: number, _r: Hex, _s: Hex): Promise<void> { | ||
| // TODO: implement | ||
| throw new Error('Method not implemented.'); | ||
| } |
There was a problem hiding this comment.
The method is currently unimplemented and throws an error. If this is not intended for the current release, it should be removed or marked with a more descriptive TODO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to gear-tech/gear#5362