Fix CI testing of installing RGBDS on Cygwin - #2038
Merged
Merged
Conversation
Rangi42
added
tests
ISSOtm
previously requested changes
Jul 30, 2026
ISSOtm
left a comment
ISSOtm
left a comment
Member
There was a problem hiding this comment.
The principle looks good to me, I'd just like a bit of rationale documented inline. Thank you ^^
Rangi42
force-pushed
the
cygwin-install
branch
2 times, most recently
from
July 31, 2026 02:12
5c538f3 to
77e8eb6
Compare
We need to pass `-e` to Cygwin `bash` explicitly, since specifying it as the non-default `shell:` no longer automatically adds `-e` behavior to `run` blocks. We also need to install to `/usr/bin` (which `cygwin-install-action` automatically adds to the `PATH`), not `/usr/local/bin` (which is not in the default `PATH`). This tests our `PREFIX`/`--prefix` handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to pass
-eto Cygwinbashexplicitly, since specifying it as the non-defaultshell:no longer automatically adds-ebehavior torunblocks.We also need to install to
/usr/bin(whichcygwin-install-actionautomatically adds to thePATH), not/usr/local/bin(which is not in the defaultPATH). This tests ourPREFIX/--prefixhandling.(I believe that instead of using
make PREFIX/cmake --prefix, we could use a login shell -- like cygwin/cygwin-install-action#29 does withbin\bash.exe -leo pipefail -o igncr '{0}'-- which would parse the Cygwin-default.bash_profile/.bashrcfiles and thereby add/usr/local/binto thePATH. But I think the current solution is more reliable, and gets to test more of our supported behavior.)