Refactor RedirectConsoleStream to use portable C++ stream buffer redirection (backport #776)#809
Merged
scpeters merged 1 commit intogz-common6from Apr 30, 2026
Merged
Conversation
…direction (#776) This is instead of the unstable OS-level `dup2` system call. This fixes reliability issues on Windows when combined with `spdlog`. The new implementation: - Redirects `std::cout` and `std::cerr` using `std::ostream::rdbuf()`. - Adds a custom `spdlog` sink (`RedirectConsoleSink`) to capture logs emitted through Gazebo logging macros (`gzmsg`, `gzerr`, etc.). - Implements level-range filtering in the custom sink to maintain the expected separation between stdout-bound logs (Trace to Info) and stderr-bound logs (Warn to Critical). Generated-By: Gemini 3 Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 94a7ce3)
9 tasks
scpeters
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
This is instead of the unstable OS-level
dup2system call. This fixes reliability issues on Windows when combined withspdlog. Should hopefuly improve the flakiness of RedirectConsoleStream.InlineHelpersThe new implementation:
std::coutandstd::cerrusingstd::ostream::rdbuf().spdlogsink (RedirectConsoleSink) to capture logs emitted through Gazebo logging macros (gzmsg,gzerr, etc.).Checklist
codecheckpassed (See contributing)Generated-by: Gemini 3.0
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
This is an automatic backport of pull request #776 done by [Mergify](https://mergify.com).