Skip to content

switched vmThreads => threads to avoid warning in tests: - #3193

Merged
gardener-prow[bot] merged 1 commit into
gardener:masterfrom
grolu:enh/switch_to_threads
Aug 18, 2026
Merged

switched vmThreads => threads to avoid warning in tests:#3193
gardener-prow[bot] merged 1 commit into
gardener:masterfrom
grolu:enh/switch_to_threads

Conversation

@grolu

@grolu grolu commented Aug 18, 2026

Copy link
Copy Markdown
Member

VM Modules is an experimental feature and might change at any time

How to categorize this PR?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


Summary by CodeRabbit

  • Tests
    • Updated test execution settings across multiple modules to use the threads-based pool.
    • Improves consistency and compatibility of automated test runs.

VM Modules is an experimental feature and might change at any time
@gardener-prow gardener-prow Bot added kind/bug Bug size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b6753445-17df-4de4-95de-2e87e24e789e

📥 Commits

Reviewing files that changed from the base of the PR and between a231e20 and f38a413.

📒 Files selected for processing (7)
  • charts/vitest.config.js
  • packages/kube-client/vitest.config.js
  • packages/kube-config/vitest.config.js
  • packages/logger/vitest.config.js
  • packages/monitor/vitest.config.js
  • packages/polling-watcher/vitest.config.js
  • packages/request/vitest.config.js

Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Vitest pool changes from vmThreads to threads in seven configuration files across the charts and package directories.

Changes

Vitest pool configuration

Layer / File(s) Summary
Update Vitest pool settings
charts/vitest.config.js, packages/*/vitest.config.js
Vitest configurations now use the threads pool instead of vmThreads.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to f38a4

This PR updates test configuration to use threads instead of VM threads to avoid warnings. The change is localized, and no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the bug classification and release note, but it omits the area and leaves the main purpose, issue, and reviewer notes sections empty. Add an /area classification and complete the sections for the change rationale, fixed issue, and reviewer notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes replacing vmThreads with threads to avoid test warnings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gardener-prow gardener-prow Bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Aug 18, 2026

@petersutter petersutter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@gardener-prow

gardener-prow Bot commented Aug 18, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: a3836c668713e7a89941b410e022f4a574e6b03c

@gardener-prow

gardener-prow Bot commented Aug 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petersutter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2026
@gardener-prow
gardener-prow Bot merged commit 74a0600 into gardener:master Aug 18, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants