Skip to content

Commit 01e3038

Browse files
authored
feat!: update models to vrs 2.0.0 community review ballot (#471)
close #469 * Update modules to vrs [2.0.0-ballot.2024-11.3](https://github.com/ga4gh/vrs/tree/2.0.0-ballot.2024-11.3) tag * Rename class `_Ga4ghIdentifiableObject` to `Ga4ghIdentifiableObject` * Removes `entity_models` and `domain_models` from `ga4gh.core`. Now, all gks-core models are in `ga4gh.core.models`. * gks-core includes `date` and `datetime` as primitives, however the builtin `datetime` module already provides these. Initially, I kept them as Pydantic Root Models but I think we should just leverage the `datetime` module instead.
1 parent 11c4f97 commit 01e3038

15 files changed

Lines changed: 409 additions & 646 deletions

File tree

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
[submodule "submodules/vrs"]
22
path = submodules/vrs
33
url = https://github.com/ga4gh/vrs.git
4-
branch = 2.x
4+
branch = 2.0.0-ballot.2024-11

src/ga4gh/core/__init__.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
from .pydantic import (
1616
is_pydantic_instance, is_curie_type, pydantic_copy
1717
)
18-
from .domain_models import CommonDomainType
19-
from . import entity_models, domain_models
18+
from . import models as core_models
2019

2120
__all__ = [
2221
"sha512t24u",
@@ -37,9 +36,7 @@
3736
"is_pydantic_instance",
3837
"is_curie_type",
3938
"pydantic_copy",
40-
"CommonDomainType",
41-
"entity_models",
42-
"domain_models"
39+
"core_models",
4340
]
4441

4542
try:

src/ga4gh/core/domain_models.py

Lines changed: 0 additions & 131 deletions
This file was deleted.

0 commit comments

Comments
 (0)