fix(search): Server-render corpus search tabs (#7035) - #7635
Open
stephenstanwood wants to merge 2 commits into
Open
fix(search): Server-render corpus search tabs (#7035)#7635stephenstanwood wants to merge 2 commits into
stephenstanwood wants to merge 2 commits into
Conversation
Render homepage corpus search tabs with Django so labels appear in the initial HTML before Alpine loads, while keeping Alpine for selection state.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
for more information, see https://pre-commit.ci
Member
|
Hi! Thanks for submitting this. It's important to look at your work to be sure it's correct. Can you please submit screenshots as well? |
Author
|
Screenshots here! Also verified with JS off: the four tab labels are in the initial HTML (no Alpine flash). 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes: #7035
Summary
The homepage search tabs were built with Alpine x-for, so they weren't in the HTML until JS ran and you got a flash. This switches the tabs to Django
{% for %}so the labels show up right away. Alpine still handles which tab is selected. I also added a test that checks the labels are in the page HTML.Deployment
This PR should:
skip-deploy(skips everything below)skip-web-deployskip-celery-deployskip-cronjob-deployskip-daemon-deployScreenshots
Desktop
I don't have local screenshots yet. Happy to add them if helpful.
Mobile
Same. Tabs are desktop-only in this UI (
hidden md:flex), so mobile still uses the scope menu.