common/update_version_env(): don't set both ABI_FILE and OSVERSION#1261
Open
svmhdvn wants to merge 1 commit intofreebsd:masterfrom
Open
common/update_version_env(): don't set both ABI_FILE and OSVERSION#1261svmhdvn wants to merge 1 commit intofreebsd:masterfrom
svmhdvn wants to merge 1 commit intofreebsd:masterfrom
Conversation
This fixes an annoying message that shows up for every built port when building with QEMU: "pkg-static: Both ABI_FILE and OSVERSION are set, ABI_FILE overrides OSVERSION"
Member
|
I'm not sure about this one. |
Member
|
@bapt how should we make this warning go away? The variables are different purposes, why is |
Member
|
if ABI_FILE is defined with a valid version I should probably ignore OSVERSION if defined in env and not via command line and bot issue warning in this case |
Member
|
aka yes this should fixed on pkg side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an annoying message that shows up for every built port when building with QEMU:
"pkg-static: Both ABI_FILE and OSVERSION are set, ABI_FILE overrides OSVERSION"