WIP: move Linux frame buffer support to base system#342
Open
wulf7 wants to merge 19 commits intofreebsd:masterfrom
Open
WIP: move Linux frame buffer support to base system#342wulf7 wants to merge 19 commits intofreebsd:masterfrom
wulf7 wants to merge 19 commits intofreebsd:masterfrom
Conversation
Member
Would be good to also indicate why they should be in the base system |
Contributor
Author
|
We a going to make drm.ko to be a part of base system |
This isn't completely true anymore, now that SimpleDRM is a thing and distros have largely replaced the traditional framebuffer with the DRM backed one. |
Generic framebufer driver is a lower layer than drm framebufer. It should not depend on later. The only usage of passing `struct drm_fb_helper` to vt_drmfb was using it as a container of reference to parent BSD device. Pass device directly from drm to vt_drmfb to not depend on drm. Sponsored by: Future Crew LLC
as vt_drmfb is the only user of skip_ddb. Keep skip_ddb sysctl declarations in drm as they are children of drm sysctl nodes. Sponsored by: Future Crew LLC
support code to consolidate it in one place. This done with adding of FreeBSD-specific fields to drm_driver structure to pass aperture parametrs from drm drivers to framebufer support code. Also remove struct apertures_struct from fb_info to follow upstream. Sponsored by: Future Crew LLC
Remove references to now unused headers, functions and kernel modules. Sponsored by: Future Crew LLC
and move them to BSD-licensed linux/fb.h Sponsored by: Future Crew LLC
While here move cfb_ declarations to BSD linux/fb.h too and remove extraneous extern keywords. Sponsored by: Future Crew LLC
to match LinuxKPI style.
They do not depend on drm internals. Add -DDEVELOPER to make options to compile linux_video.ko
…nux_fb.c They are native.
That is like most other VT drivers do.
Rename it to linuxkpi_skip_ddb as it is public symbol now.
To prevent name clashing with older drm-kmods.
This structure is used only in LKPI so no reasons to convert members to native types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, framebuffer code is not a part of drm and can be used with non-drm drivers.
The aim is to move linux_fb.c vt_drmfb.c to linuxkpi_video module and import to base system after than.
The changes clashes with ongoing drm-kmod 6.xx import doing by @dumbbell. That should be resolved in future.
Still WIP