FreeBSD: support charp module_params like hw.amdgpu.virtual_display, fixes #134#146
Draft
valpackett wants to merge 1 commit intofreebsd:masterfrom
Draft
FreeBSD: support charp module_params like hw.amdgpu.virtual_display, fixes #134#146valpackett wants to merge 1 commit intofreebsd:masterfrom
valpackett wants to merge 1 commit intofreebsd:masterfrom
Conversation
Contributor
|
Any news on that ? I see that the phab review have still some comments for part of the code. |
Contributor
Author
|
@evadot nope, no news sorry, was kinda away from FreeBSD development most of the time. Could you take a look? I think the phab patch was fully working, at least |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: https://reviews.freebsd.org/D34252