chore: update to rust edition 2024, rust-version 1.93, and add workspace lint rules#162
Open
zerosnacks wants to merge 3 commits intomainfrom
Open
chore: update to rust edition 2024, rust-version 1.93, and add workspace lint rules#162zerosnacks wants to merge 3 commits intomainfrom
zerosnacks wants to merge 3 commits intomainfrom
Conversation
…ace lint rules (#160) ## Summary Update workspace to Rust edition 2024 / MSRV 1.93 and add workspace lint rules matching `foundry-rs/foundry`. ## Changes - `edition`: 2021 → 2024 - `rust-version`: 1.76 → 1.93 - `resolver`: 2 → 3 - `clippy.toml` MSRV: 1.76 → 1.93, add `ignore-interior-mutability` - CI workflow + README MSRV references updated - Add `[workspace.lints.clippy]`, `[workspace.lints.rust]`, `[workspace.lints.rustdoc]` matching `foundry-rs/foundry` - Add `[lints] workspace = true` to both crates ## Edition 2024 fixes - Removed explicit `ref` in match pattern (`block_number.rs`) - Wrapped `env::set_var` in `unsafe` blocks (`account.rs` tests) — now unsafe in edition 2024 - Reformatted imports per edition 2024 rustfmt style ## Lint fixes - `use-self`: replaced type names with `Self` in impl blocks - `uninlined-format-args`: inlined format arguments - `redundant-clone`: removed unnecessary `.clone()` - `redundant-imports`: removed `Future` import (now in edition 2024 prelude) Prompted by: zerosnacks --------- Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
zerosnacks
commented
Apr 1, 2026
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse and
onbjerg
as code owners
zerosnacks
commented
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update workspace to Rust edition 2024 / MSRV 1.93 and add workspace lint rules matching
foundry-rs/foundry.Changes
edition: 2021 → 2024rust-version: 1.76 → 1.93resolver: 2 → 3clippy.tomlMSRV: 1.76 → 1.93, addignore-interior-mutability[workspace.lints.clippy],[workspace.lints.rust],[workspace.lints.rustdoc]matchingfoundry-rs/foundry[lints] workspace = trueto both cratesEdition 2024 fixes
refin match pattern (block_number.rs)env::set_varinunsafeblocks (account.rstests) — now unsafe in edition 2024Lint fixes
use-self: replaced type names withSelfin impl blocksuninlined-format-args: inlined format argumentsredundant-clone: removed unnecessary.clone()redundant-imports: removedFutureimport (now in edition 2024 prelude)Ref: #160