Skip to content

New design doc: Architecture of material_ui and cupertino_ui#13529

Merged
parlough merged 2 commits into
mainfrom
dkwingsmt-patch-1
Jun 22, 2026
Merged

New design doc: Architecture of material_ui and cupertino_ui#13529
parlough merged 2 commits into
mainfrom
dkwingsmt-patch-1

Conversation

@dkwingsmt

@dkwingsmt dkwingsmt commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Add /go/material-ui-cupertino-ui-architecture design doc redirect.

@dkwingsmt dkwingsmt requested review from a team and sfshaza2 as code owners June 22, 2026 21:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new redirect entry in firebase.json for /go/material_ui-cupertino_ui-architecture. The feedback suggests replacing underscores with hyphens in the source path to maintain alphabetical sorting and consistency with existing URL patterns.

Comment thread firebase.json Outdated
@flutter-website-bot

flutter-website-bot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit cab72f5):

https://flutter-docs-prod--docs-pr13529-dkwingsmt-patch-1-qy6w350s.web.app

@flutter-website-bot

flutter-website-bot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit cab72f5):

https://flutter-dev-230821--www-pr13529-dkwingsmt-patch-1-x32f3flh.web.app

@parlough parlough left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do consider using dashes in the redirect. Otherwise looks good to me. Thanks!

Comment thread firebase.json Outdated
@dkwingsmt

dkwingsmt commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

I don't hold strong opinions but I chose underscores because material_ui and cupertino_ui are package names verbatim. Do you think I should unify them to dashes?

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@parlough

Copy link
Copy Markdown
Member

Do you think I should unify them to dashes?

Yes, as that's generally how we format URL paths, even for package names.

For consistency, I went ahead and pushed the update to /go/material-ui-cupertino-ui-architecture and will land this once the checks pass.

Thanks!

@dkwingsmt

Copy link
Copy Markdown
Contributor Author

Sounds good. Thank you!

@parlough parlough merged commit 1c9bd86 into main Jun 22, 2026
14 checks passed
@parlough parlough deleted the dkwingsmt-patch-1 branch June 22, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants