Skip to content

Migrate ios_books SceneDelegate for UIScene#2845

Merged
ericwindmill merged 2 commits into
flutter:mainfrom
Wreos:migrate-uiscene-ios-books
Jun 19, 2026
Merged

Migrate ios_books SceneDelegate for UIScene#2845
ericwindmill merged 2 commits into
flutter:mainfrom
Wreos:migrate-uiscene-ios-books

Conversation

@Wreos

@Wreos Wreos commented May 23, 2026

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#176957

Migrated SceneDelegate.swift to use UI scene using this guideline https://docs.flutter.dev/release/breaking-changes/uiscenedelegate#migration-guide-for-flutter-apps for ios_books app

image

While testing this sample locally, I noticed a separate existing issue in IosBooks/ViewController.swift: the Google Books response is force-unwrapped. The unauthenticated request currently returns HTTP 429/quota errors in some environments, so json["items"] as! [[String: Any]] can crash at runtime.

I kept this PR scoped to the UIScene migration only, but I can file or send a separate follow-up to make the sample parse the API response defensively, WDYT?

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@Wreos

Wreos commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

Changelog link in checklist opens 404, since there is no root CHANGELOG.md. Should i create one?

@ericwindmill ericwindmill merged commit a6754b4 into flutter:main Jun 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants