Skip to content

fix: replace scrollableBuilder with builder in CupertinoSheetRoute fo…#2834

Merged
ericwindmill merged 3 commits into
flutter:mainfrom
Pranav2918:fix/cupertino_gallery
Jun 19, 2026
Merged

fix: replace scrollableBuilder with builder in CupertinoSheetRoute fo…#2834
ericwindmill merged 3 commits into
flutter:mainfrom
Pranav2918:fix/cupertino_gallery

Conversation

@Pranav2918

Copy link
Copy Markdown
Contributor

The CupertinoSheetRoute now correctly implements the required builder signature according to the Flutter API.

// Before
CupertinoSheetRoute<void>(
  scrollableBuilder: (BuildContext context, ScrollController controller) {
    // ...
  },
)

// After
CupertinoSheetRoute<void>(
  builder: (BuildContext context) {
    // ...
  },
)

Changes made:

  • Updated the CupertinoSheetRoute constructor to use the correct builder parameter instead of the undefined scrollableBuilder parameter.

  • Refactored the builder function to remove the unused ScrollController and simplified the internal structure for better readability.


Pre-launch Checklist

  • [✓] I read the Flutter Style Guide recently, and have followed its advice.
  • [✓] I signed the CLA.
  • [✓] I read the Contributors Guide.
  • [✓] I have added sample code updates to the changelog.
  • [✓] I updated/added relevant documentation (doc comments with ///).

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@google-cla

google-cla Bot commented Apr 21, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ericwindmill ericwindmill merged commit b538521 into flutter:main Jun 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants