Skip to content

workflows: Add verify step of CMakeLists version#11695

Closed
cosmo0920 wants to merge 1 commit intomasterfrom
cosmo0920-verify-cmakelists-version
Closed

workflows: Add verify step of CMakeLists version#11695
cosmo0920 wants to merge 1 commit intomasterfrom
cosmo0920-verify-cmakelists-version

Conversation

@cosmo0920
Copy link
Copy Markdown
Contributor

@cosmo0920 cosmo0920 commented Apr 10, 2026


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Chores
    • Enhanced staging release workflow validation to ensure more reliable and consistent release processes.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

GitHub Actions workflow updated to add full repository checkout with fetch history before version operations, and introduces bash-based validation ensuring release versions are semver-formatted, computed from the appropriate target branch, and strictly greater than previously released versions.

Changes

Cohort / File(s) Summary
Staging Release Workflow
.github/workflows/staging-release.yaml
Added repository checkout with fetch-depth: 0 before version retrieval; removed duplicate checkout step. Introduced validation logic that enforces x.y.z version format, dynamically determines target branch from minor version stream, fetches latest semver tags from origin, and validates that the release version is strictly greater than the latest merged tag (with additional minor-version matching check for non-master branches).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • niedbalski
  • patrick-stephens
  • celalettin1286

Poem

🐰 A rabbit hops with glee,
Version tags now match with care,
Semver's checked—one, two, three!
Branches fetched with git to spare,
Release flows without despair!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'workflows: Add verify step of CMakeLists version', but the actual changes add comprehensive version validation to the staging-release workflow, not CMakeLists version verification. The title is misleading. Update the title to accurately reflect the changes, such as 'workflows: Add release version validation to staging-release job' or similar that describes the actual workflow validation logic added.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cosmo0920-verify-cmakelists-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e984b8902

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +74 to +75
if [[ "$RELEASE_MM" == "4.2" ]] || (( RELEASE_MAJOR >= 5 )); then
TARGET_BRANCH="master"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Validate 4.2 releases against the 4.2 branch

This branch selection forces TARGET_BRANCH="master" for every 4.2.x release, but the same workflow still publishes 4.2 releases from target_commitish: '4.2' later in the file. That mismatch means the new version gate compares 4.2 inputs against tags on master rather than the 4.2 maintenance branch; once master has higher tags (for example 5.x), legitimate 4.2 patch releases will be rejected as “not newer,” blocking the 4.2 release path.

Useful? React with 👍 / 👎.

@cosmo0920 cosmo0920 closed this Apr 10, 2026
@cosmo0920
Copy link
Copy Markdown
Contributor Author

Needed to consider more concrete steps to merge this type of confirmations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant