workflows: Add verify step of CMakeLists version#11695
workflows: Add verify step of CMakeLists version#11695
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughGitHub Actions workflow updated to add full repository checkout with fetch history before version operations, and introduces bash-based validation ensuring release versions are semver-formatted, computed from the appropriate target branch, and strictly greater than previously released versions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e984b8902
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [[ "$RELEASE_MM" == "4.2" ]] || (( RELEASE_MAJOR >= 5 )); then | ||
| TARGET_BRANCH="master" |
There was a problem hiding this comment.
Validate 4.2 releases against the 4.2 branch
This branch selection forces TARGET_BRANCH="master" for every 4.2.x release, but the same workflow still publishes 4.2 releases from target_commitish: '4.2' later in the file. That mismatch means the new version gate compares 4.2 inputs against tags on master rather than the 4.2 maintenance branch; once master has higher tags (for example 5.x), legitimate 4.2 patch releases will be rejected as “not newer,” blocking the 4.2 release path.
Useful? React with 👍 / 👎.
|
Needed to consider more concrete steps to merge this type of confirmations. |
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit