aws_credentials: make IRSA authoritative in credentials chain#11256
aws_credentials: make IRSA authoritative in credentials chain#11256
Conversation
- Added explicit constants for IRSA environment variables to clarify detection of pod-level AWS authentication settings. - Updated the standard AWS credential chain to treat IRSA as authoritative, failing fast if the EKS provider cannot initialize and skipping ECS/EC2 fallbacks when IRSA is configured. Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModified AWS credential provider chain in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fixes #11255
Added explicit constants for IRSA environment variables to clarify detection of pod-level AWS authentication settings.
Updated the standard AWS credential chain to treat IRSA as authoritative, failing fast if the EKS provider cannot initialize and skipping ECS/EC2 fallbacks when IRSA is configured.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit
New Features
Bug Fixes