Skip to content

FOPTS-15799 Changes to make the Loadbalancer Resource ID globally unique#3657

Draft
julfkar-mu wants to merge 3 commits intomasterfrom
FOPTS-15799_fix_clbs_policy_template
Draft

FOPTS-15799 Changes to make the Loadbalancer Resource ID globally unique#3657
julfkar-mu wants to merge 3 commits intomasterfrom
FOPTS-15799_fix_clbs_policy_template

Conversation

@julfkar-mu
Copy link
Copy Markdown

@julfkar-mu julfkar-mu commented Oct 21, 2025

Description

This PR makes the "resourceID" globally unique for AWS Unused Classic Load Balancers policy.
It accomplish the uniqueness by suffixing the existing "resourceID" with " {region}".

The final format of "resourceID" is: LOAD_BALANCER_NAME (REGION)

The reason for suffixing with region is that:

  1. The current "resourceID" is the name of the load balancer
  2. The name of the load balancer is only unique within same region
  3. Suffixing the existing "resourceID" with region will make it globally unique.

aws_unused_clbs.pt

Issues Resolved

https://flexera.atlassian.net/browse/FOPTS-17159

Link to Example Applied Policy

https://app.flexeratest.com/orgs/1105/automation/incidents/projects/60073?incidentId=68f8f704cc40300dda193605

Contribution Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable
  • New functionality has been documented in CHANGELOG.MD

…e in order to resolve historical recommendation issues
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 21, 2025

2 Warnings
⚠️

Github Pull Request

[Info] Pull Request has improper title. Title should always begin with the JIRA ticket id, followed by a description, like in the following examples:

POL-123 Add New Feature
FOPTS-1000 Fixed Bug

FOAA-710 New Policy Template

⚠️

cost/aws/unused_clbs/aws_unused_clbs.pt

Policy template updated but associated README.md file has not been. Please verify that any necessary changes have been made to the README.

Generated by 🚫 Danger

Comment thread cost/aws/unused_clbs/CHANGELOG.md Outdated
Comment thread cost/aws/unused_clbs/aws_unused_clbs.pt Outdated
@julfkar-mu julfkar-mu marked this pull request as ready for review October 22, 2025 14:10
@julfkar-mu julfkar-mu requested a review from a team as a code owner October 22, 2025 14:10
@julfkar-mu julfkar-mu requested a review from XOmniverse October 22, 2025 14:11
Copy link
Copy Markdown
Contributor

@XOmniverse XOmniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Cloud Workflow functionality depends on the resource ID and would need to be adjusted to handle this change.

@julfkar-mu julfkar-mu marked this pull request as draft November 20, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants