Skip to content

Fleet UI: Fix gitops mode wonkiness #43428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RachelElysia merged 6 commits into from
Apr 14, 2026
Merged

Fleet UI: Fix gitops mode wonkiness #43428

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0796f2c
Fleet UI: Gitops styling fixes
Apr 10, 2026
033daf8
Fleet UI: Fix gitops mode wonky styling
Apr 10, 2026
bd6a2b9
changelog
Apr 10, 2026
abc673b
Update to fix form field with gitopsmode tooltip
RachelElysia Apr 13, 2026
f4e82ff
Add prop
Apr 13, 2026
68f7876
Remove local fix
Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/43341-gitops-mode-wonkiness
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fleet UI: Fixed styling bugs in GitOps mode UI
1 change: 1 addition & 0 deletions frontend/components/GitOpsModeTooltipWrapper/GitOpsModeTooltipWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { getGitOpsModeTipContent } from "utilities/helpers";

interface IGitOpsModeTooltipWrapper {
renderChildren: (disableChildren?: boolean) => React.ReactNode;
/** Positioned left in forms partially disabled by gitops mode (e.g. settings/organization/advanced) */
position?: ITooltipWrapper["position"];
tipOffset?: ITooltipWrapper["tipOffset"];
fixedPositionStrategy?: ITooltipWrapper["fixedPositionStrategy"];
Expand Down
10 changes: 10 additions & 0 deletions frontend/components/GitOpsModeTooltipWrapper/_styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@
align-items: center;
}

// Override TooltipWrapper's inline-flex so wrapped block-level form elements
// (e.g. InputField) still stretch to full width.
&.component__tooltip-wrapper {
display: flex;

.component__tooltip-wrapper__element {
white-space: normal;
}
}

.component__tooltip-wrapper {
&__tip-text {
cursor: default;
Expand Down
1 change: 0 additions & 1 deletion frontend/pages/ManageControlsPage/OSSettings/cards/DiskEncryption/DiskEncryption.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ const DiskEncryption = ({
)}
<div className="button-wrap">
<GitOpsModeTooltipWrapper
tipOffset={-12}
renderChildren={(d) => (
<Button
disabled={d}
Expand Down
1 change: 0 additions & 1 deletion ...nd/pages/admin/IntegrationsPage/cards/GlobalHostStatusWebhook/GlobalHostStatusWebhook.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ const GlobalHostStatusWebhook = ({
)}
</div>
<GitOpsModeTooltipWrapper
tipOffset={-8}
renderChildren={(disableChildren) => (
<Button
type="submit"
Expand Down
1 change: 0 additions & 1 deletion ...grationsPage/cards/IdentityProviders/components/EndUserAuthSection/EndUserAuthSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,6 @@ const EndUserAuthSection = ({
/>
</div>
<GitOpsModeTooltipWrapper
tipOffset={-8}
renderChildren={(disableChildren) => (
<TooltipWrapper
tipContent="Complete all required fields to save end user authentication."
Expand Down
1 change: 0 additions & 1 deletion frontend/pages/admin/IntegrationsPage/cards/Sso/Sso.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,6 @@ const Sso = ({
)}
</div>
<GitOpsModeTooltipWrapper
tipOffset={-8}
renderChildren={(disableChildren) => (
<Button
type="submit"
Expand Down
Loading
Loading