chore: Add more scroll-to-zoom examples and a widget-level scroll test - #4008
Merged
Conversation
luanpotter
commented
Aug 16, 2026
| final game = _ScrollCallbacksGame(); | ||
| await tester.pumpWidget(GameWidget(game: game)); | ||
| await tester.pump(); | ||
| await tester.pump(); |
Member
Author
There was a problem hiding this comment.
apparently basically all tests do this nonsense, so just replicating. can investigate further later
luanpotter
marked this pull request as ready for review
August 16, 2026 15:25
spydon
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add more scroll-to-zoom examples and a widget-level scroll test; no src changes.
fixed_resolution_exampleandstatic_components_exampleboth used to declare the legacyScrollDetectorwithout ever overridingonScroll; I removed it on the previous cleanup but I think the intent was valid, so I am adding a zoom-on-scroll behaviour that was never there other than in spirit.Also adds a widget-level scroll test missing for the callbacks; the legacy path had one but the exact shape was never added to the new system.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?