Skip to content

dev: list comparison error as warning#961

Open
kaya-david wants to merge 6 commits intomainfrom
dev-list-comparison-error-as-warning
Open

dev: list comparison error as warning#961
kaya-david wants to merge 6 commits intomainfrom
dev-list-comparison-error-as-warning

Conversation

@kaya-david
Copy link
Copy Markdown
Collaborator

@kaya-david kaya-david commented Apr 29, 2026

Description

  • Briefly summarize your changes in a few bullet points (can and should correspond to CHANGELOG.md)
  • Relates to #XXX (insert issue number here), if there is a corresponding GH issue

Assignee

  • The changes adhere to the contribution guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings (e.g. flake8/mypy/pytest/...) other than deprecations

Documentation

Code Quality

  • Patch test coverage > 95% and does not decrease
  • New code uses correct & specific type hints

How did you verify that the changes work in practice?

  • List of (preferably easy reproducible) tests including OS

Reviewer


The rendered docs for this PR can be found here.

@kaya-david kaya-david self-assigned this Apr 29, 2026
@kaya-david kaya-david force-pushed the dev-list-comparison-error-as-warning branch 3 times, most recently from dad02bd to 8b6f26e Compare April 30, 2026 09:21
@kaya-david kaya-david marked this pull request as ready for review April 30, 2026 09:25
@kaya-david kaya-david requested a review from mhoff April 30, 2026 09:25
@kaya-david kaya-david force-pushed the dev-list-comparison-error-as-warning branch from dfc593b to d27e233 Compare April 30, 2026 09:31
# Conflicts:
#	CHANGELOG.md
@kaya-david kaya-david force-pushed the dev-list-comparison-error-as-warning branch from d27e233 to baf8977 Compare April 30, 2026 09:33
Comment thread CHANGELOG.md

### Improvements

* allow `list_comparison` to continue processing if comparison list initialization fails and log a warning instead
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is a breaking change, an improvement, or a feature. :D

@kaya-david kaya-david changed the title def: list comparison error as warning dev: list comparison error as warning Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant