Skip to content

feat: add json support to getters + refactoring#959

Merged
kaya-david merged 31 commits intomainfrom
dev-getters-with-content-type
Apr 30, 2026
Merged

feat: add json support to getters + refactoring#959
kaya-david merged 31 commits intomainfrom
dev-getters-with-content-type

Conversation

@kaya-david
Copy link
Copy Markdown
Collaborator

@kaya-david kaya-david commented Apr 23, 2026 •
edited by mhoff
Loading

Description

  • add json support for list_comparison by refactoring the getters
  • add _get_raw abstract method interface
  • refactor getters and adapt public interfaces + introduce private helper methods
  • extend cache and handle content_type

Assignee

  • The changes adhere to the contribution guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings (e.g. flake8/mypy/pytest/...) other than deprecations

Documentation

Code Quality

  • Patch test coverage > 95% and does not decrease
  • New code uses correct & specific type hints

How did you verify that the changes work in practice?

  • added test cases

Reviewer

The rendered docs for this PR can be found here.

@kaya-david kaya-david self-assigned this Apr 23, 2026
@kaya-david kaya-david mentioned this pull request Apr 23, 2026
Closed
14 tasks
@kaya-david kaya-david force-pushed the dev-getters-with-content-type branch 3 times, most recently from b208f2b to 7a19613 Compare April 23, 2026 13:13
@kaya-david kaya-david requested a review from mhoff April 23, 2026 15:22
mhoff
mhoff reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mhoff mhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kaya-david I have added a few remarks

Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
@kaya-david kaya-david force-pushed the dev-getters-with-content-type branch from 8cd201c to 0495bb4 Compare April 27, 2026 09:18
@kaya-david kaya-david requested a review from mhoff April 27, 2026 09:42
@kaya-david kaya-david marked this pull request as ready for review April 27, 2026 09:43
mhoff
mhoff reviewed Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mhoff mhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kaya-david, I did another review pass

Comment thread logprep/abc/getter.py
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
@kaya-david kaya-david force-pushed the dev-getters-with-content-type branch 4 times, most recently from 32ca378 to 38c106f Compare April 28, 2026 11:45
@kaya-david kaya-david requested a review from mhoff April 28, 2026 11:53
@kaya-david kaya-david force-pushed the dev-getters-with-content-type branch from 9790f54 to 38d6083 Compare April 28, 2026 12:06
mhoff
mhoff reviewed Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mhoff mhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did another review pass

Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
Comment thread tests/unit/processor/list_comparison/test_list_comparison.py
Comment thread tests/unit/processor/list_comparison/test_list_comparison.py
Comment thread tests/unit/test_run_logprep.py Outdated
Comment thread tests/unit/test_run_ng.py Outdated
Comment thread tests/unit/util/test_getter.py Outdated
@kaya-david kaya-david force-pushed the dev-getters-with-content-type branch from 146074b to 1a3170b Compare April 28, 2026 12:56
@kaya-david kaya-david requested a review from mhoff April 28, 2026 13:04
mhoff
mhoff reviewed Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mhoff mhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kaya-david, just one pydoc remark and please add an CHANGELOG entry

Comment thread logprep/abc/getter.py
Comment thread tests/unit/util/test_getter.py
kaya-david and others added 2 commits April 28, 2026 22:43
@kaya-david @mhoff
Update logprep/abc/getter.py
6d0d9d1 
Co-authored-by: Michael Hoff <9436725+mhoff@users.noreply.github.com>
@kaya-david
docs: update CHANGELOG.md
8f4e45c
@kaya-david kaya-david requested a review from mhoff April 28, 2026 20:52
mhoff
mhoff previously approved these changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mhoff mhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaya-david kaya-david requested a review from mhoff April 29, 2026 07:46
mhoff
mhoff reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mhoff mhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor pydoc changes missing

Comment thread logprep/abc/getter.py Outdated
Comment thread logprep/abc/getter.py Outdated
@kaya-david @mhoff
Update logprep/abc/getter.py
1305f71 
Co-authored-by: Michael Hoff <9436725+mhoff@users.noreply.github.com>
@kaya-david kaya-david requested a review from mhoff April 30, 2026 06:36
mhoff
mhoff requested changes Apr 30, 2026
View reviewed changes
Comment thread logprep/abc/getter.py Outdated
@kaya-david @mhoff
Update logprep/abc/getter.py
9cdd522 
Co-authored-by: Michael Hoff <9436725+mhoff@users.noreply.github.com>
@kaya-david kaya-david requested a review from mhoff April 30, 2026 06:44
mhoff
mhoff approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mhoff mhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaya-david kaya-david merged commit 1493190 into main Apr 30, 2026
23 checks passed
@kaya-david kaya-david deleted the dev-getters-with-content-type branch April 30, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhoff mhoff mhoff approved these changes

Assignees

@kaya-david kaya-david

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaya-david @mhoff