Skip to content

[VSCODE] Fix hover cursor and styling on Configure emulator link#10623

Open
mtr002 wants to merge 2 commits into
mainfrom
mtr-fixit
Open

[VSCODE] Fix hover cursor and styling on Configure emulator link#10623
mtr002 wants to merge 2 commits into
mainfrom
mtr-fixit

Conversation

@mtr002

@mtr002 mtr002 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor
Screenshot 2026-06-10 at 2 12 32 PM

@mtr002 mtr002 requested a review from hlshen June 10, 2026 21:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the standard anchor tag with VSCodeLink in SidebarApp.tsx to fix a hover hint issue for the 'Configure emulator' link, and updates the changelog. The reviewer suggested adding href='#' and calling e.preventDefault() to ensure the link remains keyboard-focusable and accessible.

Comment thread firebase-vscode/webviews/SidebarApp.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants