chore: remove temporary Dart console warning#10584
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the temporary Dart runtime check and its associated warning message during the functions release process. The reviewer correctly noted that removing this check leaves the import of runtimeIsLanguage unused, which should be cleaned up.
I am having trouble creating individual review comments. Click here to see my feedback.
src/deploy/functions/release/index.ts (118-127)
Since the Dart runtime check has been removed, the import of runtimeIsLanguage on line 20 is now unused and should be removed.
Lyokone
approved these changes
Jun 2, 2026
demolaf
force-pushed
the
dart-console-support
branch
from
6ee05ca to
ac84cf0
Compare
shettyvarun268
approved these changes
Jun 11, 2026
shettyvarun268
left a comment
shettyvarun268
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
You might want to add an entry in the change log but overall looks okay!
demolaf
force-pushed
the
dart-console-support
branch
3 times, most recently
from
b4342af to
c9b52c8
Compare
demolaf
force-pushed
the
dart-console-support
branch
from
c9b52c8 to
8984c0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Firebase Console now supports Dart functions, so the temporary warning directing users to the Cloud Console is no longer needed.