Chore: update CI to run on Node 24, drop Node 18 and 20 from CI, maintain Node 20 engine support#1901
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the minimum required Node.js version in package.json from >=18.0.0 to >=20.0.0. The feedback points out that the integration test script (integration_test/run_tests.sh) still runs tests on obsolete Node.js versions 14 and 16, and recommends updating them to supported versions like 20 and 22 to ensure compatibility.
…tain Node 20 engine support
ajperel
force-pushed
the
ajp/upgrade-node-24
branch
from
June 11, 2026 23:07
89c163f to
5a752f4
Compare
joehan
approved these changes
Jun 11, 2026
inlined
approved these changes
Jun 12, 2026
ajperel
added this pull request to the merge queue
Jun 15, 2026
Berlioz
pushed a commit
that referenced
this pull request
Jun 22, 2026
…tain Node 20 engine support (#1901) * Chore: update CI to run on Node 24, drop Node 18 and 20 from CI, maintain Node 20 engine support * Also update run_tests.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CI is dropping support for Node 20 imminently so updating ahead of that.
Given that Node 18 runtime in decommissioned for Google Cloud Functions updating our supported runtime to 20.