Skip to content

Chore: update CI to run on Node 24, drop Node 18 and 20 from CI, maintain Node 20 engine support#1901

Merged
ajperel merged 3 commits into
masterfrom
ajp/upgrade-node-24
Jun 15, 2026
Merged

Chore: update CI to run on Node 24, drop Node 18 and 20 from CI, maintain Node 20 engine support#1901
ajperel merged 3 commits into
masterfrom
ajp/upgrade-node-24

Conversation

@ajperel

@ajperel ajperel commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Our CI is dropping support for Node 20 imminently so updating ahead of that.

Given that Node 18 runtime in decommissioned for Google Cloud Functions updating our supported runtime to 20.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum required Node.js version in package.json from >=18.0.0 to >=20.0.0. The feedback points out that the integration test script (integration_test/run_tests.sh) still runs tests on obsolete Node.js versions 14 and 16, and recommends updating them to supported versions like 20 and 22 to ensure compatibility.

Comment thread package.json
@ajperel
ajperel force-pushed the ajp/upgrade-node-24 branch from 89c163f to 5a752f4 Compare June 11, 2026 23:07
@ajperel
ajperel requested review from inlined and joehan June 11, 2026 23:07
@ajperel
ajperel added this pull request to the merge queue Jun 15, 2026
Merged via the queue into master with commit 3b325ff Jun 15, 2026
25 checks passed
Berlioz pushed a commit that referenced this pull request Jun 22, 2026
…tain Node 20 engine support (#1901)

* Chore: update CI to run on Node 24, drop Node 18 and 20 from CI, maintain Node 20 engine support

* Also update run_tests.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants