feat(storage): add StringLoader to support loading gs:// URL strings directly via Glide#2335
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for loading images directly from a gs:// URL string in Glide, including documentation updates in the README and the implementation of StringLoader in FirebaseImageLoader.java. The reviewer suggested improving the flexibility and testability of StringLoader by allowing it to accept a custom FirebaseStorage instance, as well as catching IllegalStateException to handle initialization edge cases gracefully.
…instance and add unit tests
just1and0
approved these changes
Jun 17, 2026
just1and0
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Nice work with this one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1842 .
Changes
FirebaseImageLoaderpreviously only accepted aStorageReferenceas the Glide model, meaning callers who stored image paths asgs://strings (e.g. retrieved from Firestore) had to manually convert them before loading.StringLoadereliminates that conversion by intercepting any string starting withgs://and delegating to the existingFirebaseStorageFetcher.Usage
Register
StringLoader.Factoryalongside the existing loader in yourAppGlideModule:You can then pass a
gs://URL string directly to Glide:Preview