Code Quality: Remove reflection-based Path lookup from SidebarItem#18452
Closed
0x5bfa wants to merge 4 commits into
Closed
Code Quality: Remove reflection-based Path lookup from SidebarItem#184520x5bfa wants to merge 4 commits into
0x5bfa wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes reflection-based access to a sidebar item’s filesystem path and replaces it with a strongly-typed Path member on ISidebarItemModel, improving performance and type safety for drag-related logic.
Changes:
- Replaced reflection-based
"Path"property lookup withISidebarItemModel.PathinSidebarItem. - Added a
Pathmember toISidebarItemModel(defaulting tonull) to support the new strongly-typed access pattern.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Files.App.Controls/Sidebar/SidebarItem.cs | Uses Item.Path directly for CanDrag and drag-start path validation (removes reflection). |
| src/Files.App.Controls/Sidebar/ISidebarItemModel.cs | Introduces Path on the model interface to support non-reflection access. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Ready |
marcelwgn
approved these changes
May 17, 2026
yair100
added
the
ready to merge
Member
|
I missed that this was approved, thank you @marcelwgn and @0x5bfa. |
Member
Author
|
bruh sorry, i clicked a wrong button. :/ |
Member
|
Can you please rebase from |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: 0x5BFA <62196528+0x5bfa@users.noreply.github.com>
0x5bfa
force-pushed
the
5bfa/CQ-Reflection1
branch
from
May 31, 2026 15:48
bf9bd20 to
b69a735
Compare
Member
Author
|
Looks like this PR no longer needed as someone already did this in some commit lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes