Skip to content

fix(ts-sdk): apply license config to publish output mode in package.json#14893

Open
Ryan-Amirthan wants to merge 1 commit intomainfrom
devin/1775840338-fix-license-field-publish-mode
Open

fix(ts-sdk): apply license config to publish output mode in package.json#14893
Ryan-Amirthan wants to merge 1 commit intomainfrom
devin/1775840338-fix-license-field-publish-mode

Conversation

@Ryan-Amirthan
Copy link
Copy Markdown
Contributor

Description

Fixes the license field being missing from generated package.json when using the publish output mode. The license configuration from generators.yml was only applied for the github output mode; the publish case hardcoded license: undefined.

Changes Made

  • constructNpmPackage.ts: Use licenseFromLicenseConfig(generatorConfig.license) in the "publish" output mode case instead of hardcoding undefined
  • constructNpmPackage.ts: Refactor the "github" case to also use the shared licenseFromLicenseConfig helper instead of an inline _visit call (same behavior, reduces duplication)
  • Added versions.yml entry for 3.63.4

Review Checklist

  • Verify licenseFromLicenseConfig (lines 113-119 of the file) handles the same basic/custom/_other cases as the removed inline _visit in the github branch
  • Confirm no behavioral change to the downloadFiles case (returns undefined early, untouched)

Testing

  • Manual testing completed — lint passes (pnpm run check)
  • No unit tests added; this is a one-line plumbing fix using an existing helper that was already tested via the constructNpmPackageFromArgs path

Link to Devin session: https://app.devin.ai/sessions/0c24018e60484ac0b7cead2b0c91d1fc
Requested by: @Ryan-Amirthan

Co-Authored-By: ryanstep <ryanstep@umich.edu>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions
Copy link
Copy Markdown
Contributor

SDK Generation Benchmark Results

Comparing PR branch against latest nightly baseline on main (2026-04-10T04:56:48Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
ts-sdk square 102s 129s 97s -5s (-4.9%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-04-10T04:56:48Z). Trigger benchmark-baseline to refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant