fix(ts-sdk): apply license config to publish output mode in package.json#14893
fix(ts-sdk): apply license config to publish output mode in package.json#14893Ryan-Amirthan wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: ryanstep <ryanstep@umich.edu>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
SDK Generation Benchmark ResultsComparing PR branch against latest nightly baseline on Full benchmark table (click to expand)
main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via |
Description
Fixes the
licensefield being missing from generatedpackage.jsonwhen using thepublishoutput mode. The license configuration fromgenerators.ymlwas only applied for thegithuboutput mode; thepublishcase hardcodedlicense: undefined.Changes Made
constructNpmPackage.ts: UselicenseFromLicenseConfig(generatorConfig.license)in the"publish"output mode case instead of hardcodingundefinedconstructNpmPackage.ts: Refactor the"github"case to also use the sharedlicenseFromLicenseConfighelper instead of an inline_visitcall (same behavior, reduces duplication)versions.ymlentry for 3.63.4Review Checklist
licenseFromLicenseConfig(lines 113-119 of the file) handles the samebasic/custom/_othercases as the removed inline_visitin thegithubbranchdownloadFilescase (returnsundefinedearly, untouched)Testing
pnpm run check)constructNpmPackageFromArgspathLink to Devin session: https://app.devin.ai/sessions/0c24018e60484ac0b7cead2b0c91d1fc
Requested by: @Ryan-Amirthan