[compiler playground] Use TS model for typescript language input#36523
Open
ianduvall wants to merge 1 commit into
Open
[compiler playground] Use TS model for typescript language input#36523ianduvall wants to merge 1 commit into
ianduvall wants to merge 1 commit into
Conversation
ianduvall
force-pushed
the
ianduvall/playground-monaco-typescript
branch
from
bd600e4 to
b360673
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playground forced every source into a
file:///index.jsMonaco model bound to the JS language service, so TypeScript-only syntax (as, parameter type annotations) rendered with persistent "can only be used in TypeScript files." diagnostics even when the language picker was set to TypeScript.When the language is
typescript, load anindex.tsxmodel withlanguage: 'typescript'so Monaco's TS service parses TS syntax natively without those squiggles. Flow input still uses the JS model with semantic validation suppressed, since Monaco doesn't ship Flow as a built-in language.Flow support remains unchanged.