R Package: Update C++ Version to Comply with CRAN Policy#2707
R Package: Update C++ Version to Comply with CRAN Policy#2707tcuongd merged 5 commits intofacebook:mainfrom
Conversation
Co-authored-by: mitokic <16709433+mitokic@users.noreply.github.com>
Upgrade C++ standard to C++17
|
Hi @mitokic! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@laresbernardo Do we also need this line from your PR: https://github.com/facebook/prophet/pull/2706/files#diff-cc9e352c36f6a354cf85fdcc8cfcf4e629234c6084f29167136a1f13a3439e39R17 ? |
|
Yes, but with actual real information. To submit a package to CRAN it must have one valid maintainer with an email that will be used to confirm the submission. And also an explanation of why the maintainer has changed (which in this case will be easy to explain).
And also, I would update the version to clearly identify this new version.
|
|
@laresbernardo good point on the version. Just updated to 1.1.7. If you think we need to make a more major update to 1.2.0 let me know and I can make the change. @tcuongd can you serve as the maintainer of the package? Or do we need to reach out to others from Meta? |
|
Yeah put me as maintainer since I have push perms to the repo. In the future we'll probably want a different R maintainer. |
Updated authors list in DESCRIPTION file.
|
@tcuongd I updated the description file to make you the maintainer for now. Please take a look. If everything looks good please submit latest package to CRAN for approval. |
This pull request updates the package's C++ standard requirement from C++14 to C++17 across build configuration files. This ensures compatibility with newer C++ features and dependencies that may require C++17.
Build system updates:
SystemRequirementsfield inR/DESCRIPTIONfrom "C++11" to "C++17" to reflect the new minimum C++ standard for building the package.CXX_STDvariable fromCXX14toCXX17in bothR/src/MakevarsandR/src/Makevars.winto enforce C++17 during compilation on all platforms. [1] [2]Research: