Skip to content

R Package: Update C++ Version to Comply with CRAN Policy#2707

Merged
tcuongd merged 5 commits intofacebook:mainfrom
mitokic:main
Jan 21, 2026
Merged

R Package: Update C++ Version to Comply with CRAN Policy#2707
tcuongd merged 5 commits intofacebook:mainfrom
mitokic:main

Conversation

@mitokic
Copy link
Copy Markdown
Contributor

@mitokic mitokic commented Jan 20, 2026

This pull request updates the package's C++ standard requirement from C++14 to C++17 across build configuration files. This ensures compatibility with newer C++ features and dependencies that may require C++17.

Build system updates:

  • Changed the SystemRequirements field in R/DESCRIPTION from "C++11" to "C++17" to reflect the new minimum C++ standard for building the package.
  • Updated the CXX_STD variable from CXX14 to CXX17 in both R/src/Makevars and R/src/Makevars.win to enforce C++17 during compilation on all platforms. [1] [2]

Research:

Copilot AI and others added 3 commits January 20, 2026 17:22
Co-authored-by: mitokic <16709433+mitokic@users.noreply.github.com>
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Jan 20, 2026

Hi @mitokic!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Jan 20, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Jan 20, 2026
@tcuongd
Copy link
Copy Markdown
Collaborator

tcuongd commented Jan 20, 2026

@laresbernardo
Copy link
Copy Markdown
Contributor

laresbernardo commented Jan 20, 2026 via email

@mitokic
Copy link
Copy Markdown
Contributor Author

mitokic commented Jan 20, 2026

@laresbernardo good point on the version. Just updated to 1.1.7. If you think we need to make a more major update to 1.2.0 let me know and I can make the change.

@tcuongd can you serve as the maintainer of the package? Or do we need to reach out to others from Meta?

@tcuongd
Copy link
Copy Markdown
Collaborator

tcuongd commented Jan 20, 2026

Yeah put me as maintainer since I have push perms to the repo. In the future we'll probably want a different R maintainer.

Updated authors list in DESCRIPTION file.
@mitokic
Copy link
Copy Markdown
Contributor Author

mitokic commented Jan 20, 2026

@tcuongd I updated the description file to make you the maintainer for now. Please take a look.

If everything looks good please submit latest package to CRAN for approval.

@tcuongd tcuongd merged commit 18d6f55 into facebook:main Jan 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants