Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes and streamlines the R CI workflow by updating the runner image and package manager, centralizing dependency setup, and adding key environment variables.
- Switched to
ubuntu-latestand updated RSPM URL to posit.co - Added
GITHUB_PAT,R_KEEP_PKG_SOURCE, andPKGDIRenvironment variables - Replaced manual dependency commands with
r-lib/actions/setup-r-dependencies
Comments suppressed due to low confidence (1)
.github/workflows/build-and-test.yml:90
- This
working-directorykey is indented under the previous step instead of its intended action. Align it with the correspondingusesline for thecheck-r-packagestep so it applies correctly.
working-directory: ${{ env.PKGDIR }}
| any::testthat | ||
| any::readr | ||
| any::rmarkdown | ||
| needs: check |
There was a problem hiding this comment.
The needs attribute is placed under the action's with block, but it should be declared at the job level. Move needs: check out of the with section to define a job dependency correctly.
Suggested change
| needs: check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.