Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a cleanup() method to remove temporary files after model fitting, notably for CmdStan backends. Key changes include:
- Adding a cleanup method stub and an implemented version in python/prophet/models.py.
- Introducing the IStanBackend type in python/prophet/forecaster.py.
- Updating python/prophet/diagnostics.py to call the newly added cleanup() method on the stan_backend.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/prophet/models.py | Introduces two cleanup() methods; one is a stub and another with logic. |
| python/prophet/forecaster.py | Adds the stan_backend attribute and IStanBackend import. |
| python/prophet/diagnostics.py | Calls cleanup() on stan_backend and adds type annotation to prophet_copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2668