C image bindings: Add null pointer checks#3394
Conversation
|
Please properly disclose AI usage. Check only the correct checkbox. In the top part too. |
|
Thanks for fixing it @SahilSonar-04 ! |
mwestphal
left a comment
There was a problem hiding this comment.
Looks fine however I think that:
- (almost) each of these should print an error
- all the docs should be updated
Wouldn't these cause inconsistencies ? |
Maybe I'm wrong about printing an error, thats why I asked for @Meakk input. However the doc defintely should mention this behavior, if it does not, it is missing. |
|
Done with the documentation , Do let me know if any changes required , also about the error messages |
|
\ci fast |
mwestphal
left a comment
There was a problem hiding this comment.
other small changes, also CI is red
|
\ci extended |
|
\ci full |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3394 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 216 216
Lines 18750 18771 +21
=======================================
+ Hits 18203 18224 +21
Misses 547 547 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Added Null Pointer checks for image c bindings
Fixes Issue : #3393
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure