Skip to content

Go to frame api#3354

Open
Ni-g-3l wants to merge 13 commits into
f3d-app:masterfrom
Ni-g-3l:go-to-frame-api
Open

Go to frame api#3354
Ni-g-3l wants to merge 13 commits into
f3d-app:masterfrom
Ni-g-3l:go-to-frame-api

Conversation

@Ni-g-3l

@Ni-g-3l Ni-g-3l commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

Add some API to handle jump to frame and jump to keyframe
Method added :

  • jump_to_frame
  • jump_to_frame_relative
  • jump_to_keyframe
  • jump_to_keyframe_relative
  • get_delta_time
  • get_animation_frame
  • get_animation_time

Each of those method have their bindings too

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I did not use AI to generate any of the content of that pull request
  • I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.

OpenCode model were used to generate documentation in bindings

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Ni-g-3l
Ni-g-3l requested a review from a team as a code owner July 9, 2026 08:51
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

@Ni-g-3l

Ni-g-3l commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

\ci fast

@Ni-g-3l

Ni-g-3l commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

\ci main

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.11%. Comparing base (00976fd) to head (9d9aaee).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
library/src/animationManager.cxx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3354      +/-   ##
==========================================
+ Coverage   97.06%   97.11%   +0.05%     
==========================================
  Files         213      213              
  Lines       18098    18159      +61     
==========================================
+ Hits        17566    17636      +70     
+ Misses        532      523       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI red, do not hesitate to request a review when ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants