Skip to content

Add color option for normal glyphs attributes#3343

Open
Sukumarsawant wants to merge 15 commits into
f3d-app:masterfrom
Sukumarsawant:glyphs
Open

Add color option for normal glyphs attributes#3343
Sukumarsawant wants to merge 15 commits into
f3d-app:masterfrom
Sukumarsawant:glyphs

Conversation

@Sukumarsawant

@Sukumarsawant Sukumarsawant commented Jul 6, 2026

Copy link
Copy Markdown

Describe your changes

Adds the color option for normal glyphs with tests and image
part of #3120

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I did not use AI to generate any of the content of that pull request
  • I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
  • ...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Sukumarsawant

Sukumarsawant commented Jul 6, 2026

Copy link
Copy Markdown
Author

\ci fast

@Sukumarsawant

Sukumarsawant commented Jul 7, 2026

Copy link
Copy Markdown
Author

\ci main

@Sukumarsawant
Sukumarsawant marked this pull request as ready for review July 7, 2026 09:08
@Sukumarsawant
Sukumarsawant requested a review from a team as a code owner July 7, 2026 09:08
@Sukumarsawant Sukumarsawant changed the title Add options to tweak normal glyphs attributes Add color option for normal glyphs attributes Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.06%. Comparing base (00976fd) to head (51f04fd).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3343   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files         213      213           
  Lines       18098    18111   +13     
=======================================
+ Hits        17566    17579   +13     
  Misses        532      532           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Sukumarsawant

Copy link
Copy Markdown
Author

\ci full

@Meakk Meakk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good! Please address the documentation suggestions.

Comment thread doc/libf3d/03-OPTIONS.md
Comment thread doc/user/03-OPTIONS.md
Comment thread resources/cli-options.json Outdated
@Sukumarsawant

Copy link
Copy Markdown
Author

\ci full

Comment thread application/testing/tests.documentation.cmake
@mwestphal
mwestphal self-requested a review July 7, 2026 17:19
Comment thread vtkext/private/module/vtkF3DRenderer.h
Comment thread library/options.json
Comment thread vtkext/private/module/vtkF3DRenderer.cxx

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes needed

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

❌ Invalid CI command "full"

@Sukumarsawant
Sukumarsawant requested review from Meakk and mwestphal July 8, 2026 10:23
@Sukumarsawant

Copy link
Copy Markdown
Author

checking failures .

@mwestphal

Copy link
Copy Markdown
Member

not ready for full ci

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not ready, lets discuss :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants