Add pseudo unit test helper for C bindings and convert all C binding tests by SahilSonar-04 · Pull Request #3342 · f3d-app/f3d

SahilSonar-04 · 2026-07-06T13:40:21Z

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

I have performed a self-review of my code
I have added tests for new features and bugfixes
I have added documentation for new features
If it is a modifying the libf3d API, I have updated bindings
If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

I did not use AI to generate any of the content of that pull request
I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

mwestphal

looks good at first glance, will do a deep review later.
Also please make sure to rebase on master regularly and add any new tests that may be needed

SahilSonar-04 · 2026-07-07T16:21:27Z

\ci fast

mwestphal · 2026-07-07T17:30:49Z

 {
  if (!img || !reference)
  {
    return 1;


is this one wrong too ?

[DELETED because of AI policy breach]

@SahilSonar-04 do NOT use GenAI to write comments. I've deleted it as per our AI policy: https://f3d.app/dev/AI_POLICY

mwestphal · 2026-07-07T17:32:08Z

+  f3d_test_check(test, label, actual == expected);
+}
+
+static inline int f3d_test_result(const f3d_test_t* test)


missing a doc

mwestphal · 2026-07-07T17:36:16Z

+  f3d_test_check(&test, "transform bindings reach the camera and change its state",
+    state_after_transforms.position[0] != state_before_transforms.position[0] ||
+    state_after_transforms.position[1] != state_before_transforms.position[1] ||
+    state_after_transforms.position[2] != state_before_transforms.position[2] ||
+    state_after_transforms.focal_point[0] != state_before_transforms.focal_point[0] ||
+    state_after_transforms.focal_point[1] != state_before_transforms.focal_point[1] ||
+    state_after_transforms.focal_point[2] != state_before_transforms.focal_point[2] ||
+    state_after_transforms.view_up[0] != state_before_transforms.view_up[0] ||
+    state_after_transforms.view_up[1] != state_before_transforms.view_up[1] ||
+    state_after_transforms.view_up[2] != state_before_transforms.view_up[2] ||
+    state_after_transforms.view_angle != state_before_transforms.view_angle);


use the vector version ?

mwestphal · 2026-07-07T17:39:05Z

+  f3d_test_check(&test, "interactor retrieved from windowed engine", interactor != NULL);

-  f3d_engine_set_cache_path(engine, "/tmp/f3d_test_cache");
+  int cache_ret = f3d_engine_set_cache_path(engine, "/tmp/f3d_test_cache");


definitely not a valid path on all platforms though, use F3D_TESTING_TEMP_DIR

mwestphal · 2026-07-07T17:39:34Z

+  int load_native = f3d_engine_load_plugin("native");
+  f3d_test_check_int(&test, "loading the native plugin succeeds", load_native, 1);


Suggested change

int load_native = f3d_engine_load_plugin("native");

f3d_test_check_int(&test, "loading the native plugin succeeds", load_native, 1);

f3d_test_check_int(&test, "loading the native plugin succeeds", f3d_engine_load_plugin("native"), 1);

unless im missing something, you can use this pattern everywhere

mwestphal · 2026-07-07T17:43:37Z

+    &test, "get_readers_info() returns at least one reader", readers && reader_count > 0);
  f3d_engine_free_readers_info(readers);

+  // set_options with the engine's own options has no distinct observable effect to check


then maybe create a new options?

f3d_options_t* standalone_options = f3d_options_create(); you can then check get it again and check pointers are different

mwestphal · 2026-07-07T17:45:07Z

+  f3d_test_check(&test, "get_content returns non-null buffer", content != NULL);
  if (content)
  {
+    // just a roundtrip, no observable state change beyond not crashing


then maybe better to create a new image and check pointers are different

mwestphal · 2026-07-07T17:46:15Z

+  int play_ret = f3d_interactor_play_interaction(interactor, "/nonexistent.log", 1.0 / 30.0);
+  f3d_test_check(&test, "playing a nonexistent interaction file reports failure", play_ret == 0);
+
+  int record_ret = f3d_interactor_record_interaction(interactor, "/tmp/test_interaction.log");


use proper temp dir

mwestphal · 2026-07-07T17:47:54Z

+  f3d_test_check_int(&test, "double vector count matches", (long)out_count, 3);
+  f3d_test_check_double(&test, "double vector[0] matches", out_vec[0], vec_values[0], 1e-9);
+  f3d_test_check_double(&test, "double vector[1] matches", out_vec[1], vec_values[1], 1e-9);
+  f3d_test_check_double(&test, "double vector[2] matches", out_vec[2], vec_values[2], 1e-9);


use vector version

mwestphal · 2026-07-07T17:48:00Z

  f3d_options_get_as_int_vector(options, "scene.animation.indices", out_int_vec, &out_int_count);
+  f3d_test_check_int(&test, "int vector count matches", (long)out_int_count, 2);
+  f3d_test_check_int(&test, "int vector[0] matches", out_int_vec[0], int_vec_values[0]);
+  f3d_test_check_int(&test, "int vector[1] matches", out_int_vec[1], int_vec_values[1]);


use vector version

mwestphal · 2026-07-07T17:48:51Z

+  f3d_test_check_int(&test, "parsed double vector count matches", (long)parsed_dvec_count, 3);
+  f3d_test_check_double(&test, "parsed double vector[0] matches", parsed_dvec[0], 1.0, 1e-9);
+  f3d_test_check_double(&test, "parsed double vector[1] matches", parsed_dvec[1], 2.0, 1e-9);
+  f3d_test_check_double(&test, "parsed double vector[2] matches", parsed_dvec[2], 3.0, 1e-9);


use vector version

mwestphal · 2026-07-07T17:49:24Z

+  f3d_test_init(&boundary);
+  f3d_test_check_double(&boundary, "exactly at tolerance boundary fails", 1.1, 1.0, 0.1);
+  int boundary_ok = (boundary.fail_count == 1);
+


missing some methods it looks like

mwestphal

changes needed

mwestphal · 2026-07-07T18:08:31Z

Please check the checkboxes in the description, especially the AI disclosure part.

github-actions · 2026-07-07T18:17:13Z

Style Checks CI failed:

diff --git a/c/testing/pseudo_unit_test.h b/c/testing/pseudo_unit_test.h
index 78d6c0d..b3e7b03 100644
--- a/c/testing/pseudo_unit_test.h
+++ b/c/testing/pseudo_unit_test.h
@@ -1,10 +1,10 @@
 #ifndef f3d_pseudo_unit_test_h
 #define f3d_pseudo_unit_test_h
 
+#include <float.h>
 #include <math.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <float.h>
 #include <string.h>
 
 typedef struct
@@ -43,8 +43,7 @@ static inline void f3d_test_check_double(
 }
 
 // check equality of two integers
-static inline void f3d_test_check_int(
-  f3d_test_t* test, const char* label, int actual, int expected)
+static inline void f3d_test_check_int(f3d_test_t* test, const char* label, int actual, int expected)
 {
   f3d_test_check(test, label, actual == expected);
 }
@@ -57,15 +56,12 @@ static inline void f3d_test_check_vec3(
   char full_label[256];
 
   snprintf(full_label, sizeof(full_label),
-    "%s (actual=[%.6g, %.6g, %.6g], expected=[%.6g, %.6g, %.6g])",
-    label,
-    actual[0], actual[1], actual[2],
-    expected[0], expected[1], expected[2]);
+    "%s (actual=[%.6g, %.6g, %.6g], expected=[%.6g, %.6g, %.6g])", label, actual[0], actual[1],
+    actual[2], expected[0], expected[1], expected[2]);
 
   f3d_test_check(test, full_label,
-    fabs(actual[0] - expected[0]) < tol &&
-    fabs(actual[1] - expected[1]) < tol &&
-    fabs(actual[2] - expected[2]) < tol);
+    fabs(actual[0] - expected[0]) < tol && fabs(actual[1] - expected[1]) < tol &&
+      fabs(actual[2] - expected[2]) < tol);
 }
 
 // check equality of two strings
@@ -87,18 +83,16 @@ static inline void f3d_test_check_string(
 }
 
 // check that a pointer is not NULL
-static inline void f3d_test_check_ptr(
-  f3d_test_t* test, const char* label, const void* ptr)
+static inline void f3d_test_check_ptr(f3d_test_t* test, const char* label, const void* ptr)
 {
   f3d_test_check(test, label, ptr != NULL);
 }
 
 // check that a pointer is NULL
-static inline void f3d_test_check_null(
-  f3d_test_t* test, const char* label, const void* ptr)
+static inline void f3d_test_check_null(f3d_test_t* test, const char* label, const void* ptr)
 {
   f3d_test_check(test, label, ptr == NULL);
-} 
+}
 
 // check equality of two size_t values
 static inline void f3d_test_check_size(

You can copy the patch above and apply it locally with:

Platform	Command
X	`xclip -o -selection clipboard \| git apply -v`
Wayland	`wl-paste \| git apply -v`
Powershell	`Get-Clipboard -Raw \| git apply -v`
macOS	`pbpaste \| git apply -v`

Co-authored-by: Michael MIGLIORE <mcmigliore@gmail.com>

…defines instead of __linux__

SahilSonar-04 changed the title ~~Add C pseudo unit test helper with self-test~~ Add pseudo unit test helper for C bindings and convert all C binding tests Jul 7, 2026

SahilSonar-04 marked this pull request as ready for review July 7, 2026 05:54

SahilSonar-04 requested a review from a team as a code owner July 7, 2026 05:54

mwestphal requested changes Jul 7, 2026

View reviewed changes

mwestphal requested a review from Meakk July 7, 2026 06:05

SahilSonar-04 requested a review from mwestphal July 7, 2026 11:57

Meakk requested changes Jul 7, 2026

View reviewed changes

Comment thread c/testing/test_camera.c Outdated

Comment thread c/testing/test_context.c Outdated

Comment thread c/testing/test_context.c Outdated

SahilSonar-04 force-pushed the c-bindings-test-framework branch from d1e3172 to 328ef63 Compare July 7, 2026 15:19

SahilSonar-04 requested a review from Meakk July 7, 2026 16:17

mwestphal reviewed Jul 7, 2026

View reviewed changes

Comment thread c/testing/pseudo_unit_test.h Outdated

mwestphal reviewed Jul 7, 2026

View reviewed changes

mwestphal requested changes Jul 7, 2026

View reviewed changes

mwestphal added the ci:fast label Jul 7, 2026

SahilSonar-04 force-pushed the c-bindings-test-framework branch 2 times, most recently from 0b24cf5 to 8a290eb Compare July 14, 2026 13:24

SahilSonar-04 force-pushed the c-bindings-test-framework branch from fff0be8 to 787b754 Compare July 17, 2026 18:32

SahilSonar-04 and others added 29 commits July 18, 2026 00:10

Fixed Line Endings

0b4cac7

Removed first person comments

1248a46

removed unnecessary comment and function calls

ce4a4c2

Fixed some guesswork

82ce819

Fixed a bug returning wrong value

3628311

added more camera tests rather than direct calls

f08879e

added more image tests rather than direct calls

899cd40

Added few assertions

42cb52a

Variable buffer size rather than fixed

498629b

Added few assertions

9078c09

Update c/testing/test_context.c

97799e0

Co-authored-by: Michael MIGLIORE <mcmigliore@gmail.com>

modularized the code

95c5f1f

test(context): guard context backend tests with F3D_TESTING_ENABLE_* …

abb5f78

…defines instead of __linux__

Test for Double Check now has a fixed tolerance

09c5fcb

vec3 double tester tolerance is now constant

3c5964c

Fixed int test checker to take int as argument rather than long

a5ef897

proper unit test for test_types(incomplete)

45cc958

Added helpers for utils testing

a33a716

Added an environment property for testing utils

a5218f3

utils test completed

74fc7c3

improved formatting

0465343

Completed window c binding tests

22f6cdb

Completed camera c binding tests

8a71637

Completed context c binding tests

ce44b76

test engine tests written but some todo's remain

87f4c3e

Handle Null Crashes

0122d21

New variable for build dir path

850a7e0

Tests for interactor c binding completed

1da6a96

test image incomplete

a273322

SahilSonar-04 force-pushed the c-bindings-test-framework branch from 787b754 to a273322 Compare July 17, 2026 18:40

		int load_native = f3d_engine_load_plugin("native");
		f3d_test_check_int(&test, "loading the native plugin succeeds", load_native, 1);

Uh oh!

Uh oh!

Conversation

SahilSonar-04 commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

AI Disclosure

Continuous integration

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SahilSonar-04 commented Jul 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SahilSonar-04 Jul 7, 2026 • edited by mwestphal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

mwestphal commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SahilSonar-04 commented Jul 6, 2026 •

edited

Loading

SahilSonar-04 Jul 7, 2026 •

edited by mwestphal

Loading

github-actions Bot commented Jul 7, 2026 •

edited

Loading