Add config option to limit which string literal encodings are used#356
Merged
Conversation
encounter
reviewed
Jun 1, 2026
| let rect = rect.shrink(4.0); | ||
| let color = ui.visuals().text_color(); | ||
| let line_stroke = Stroke::new(1.0, color); | ||
| let line_stroke = Stroke::new(1.0_f32, color); |
Owner
There was a problem hiding this comment.
was this a clippy thing or something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new "Preferred string encoding" dropdown option to specify which encoding objdiff should try to use for decoding all string literals.
The default option is "Auto" which retains the current behavior of displaying strings with every supported encoding. If any other option is selected, then only that one encoding will be displayed. This also affects diffing results, and specifying the correct encoding can help prevent false mismatches from appearing.
It's recommended to force this option via per-project objdiff settings. For example, dtk-template projects can put the following in configure.py to use Shift JIS encoding: