RFC#999 - {{hash}} as keyword#21334
Merged
NullVoxPopuli merged 4 commits intoemberjs:mainfrom Apr 22, 2026
Merged
Conversation
Add hash to the built-in keywords map so it no longer needs to be imported in strict-mode (gjs/gts) templates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
mansona
suggested changes
Apr 21, 2026
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
We're looking at this during the spec meeting and I have a few points:
- I'm not exactly sure that the
@glimmer-workspacetests adequately test what happens when you do import the helper in an app. Maybe we should add a test to the smoke test scenario? - we should probably check (again in a smoke-test) that we can override hash with something else (I don't know what we should replace it with 😂)
Contributor
Author
|
Tests updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hash to the built-in keywords map so it no longer needs to be imported in strict-mode (gjs/gts) templates.
Implements RFC 999: https://rfcs.emberjs.com/id/0999-make-hash-built-in