Skip to content

Guard tooltip positioning after unmount #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Federicorao wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Guard tooltip positioning after unmount #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-tooltips-move.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@embedpdf/snippet': patch
---

Guard tooltip positioning when the tooltip unmounts before Floating UI resolves.
16 changes: 12 additions & 4 deletions viewers/snippet/src/components/ui/tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,23 +49,31 @@ export function Tooltip({
if (!reference.current?.base || !floating.current) return;

return autoUpdate(reference.current.base, floating.current, () => {
computePosition(reference.current!.base, floating.current!, {
const referenceEl = reference.current?.base;
const floatingEl = floating.current;
const arrowEl = arrow.current;

if (!referenceEl || !floatingEl || !arrowEl) return;

computePosition(referenceEl, floatingEl, {
placement: position,
middleware: [
offset(8),
flip(),
shift({ padding: 8 }),
arrowMw({ element: arrow.current!, padding: 6 }),
arrowMw({ element: arrowEl, padding: 6 }),
],
}).then(({ x, y, placement, middlewareData }) => {
Object.assign(floating.current!.style, { left: `${x}px`, top: `${y}px` });
if (!floating.current || !arrow.current) return;

Object.assign(floating.current.style, { left: `${x}px`, top: `${y}px` });

const { x: ax, y: ay } = middlewareData.arrow ?? {};
const side = placement.split('-')[0] as 'top' | 'bottom' | 'left' | 'right';
const staticSide = { top: 'bottom', bottom: 'top', left: 'right', right: 'left' }[side];

/* --- **critical change**: clear the axis we don't use --- */
Object.assign(arrow.current!.style, {
Object.assign(arrow.current.style, {
left: ax != null ? `${ax}px` : '',
top: ay != null ? `${ay}px` : '',
right: '',
Expand Down