Share search property filter dispatch - #1962
Merged
igordayen merged 1 commit intoAug 23, 2026
Merged
Conversation
igordayen
reviewed
Aug 21, 2026
igordayen
left a comment
igordayen
left a comment
Contributor
There was a problem hiding this comment.
@arnabnandy7 - thanks for contributing, few non-blocking observations. thanks
jasperblues
requested changes
Aug 21, 2026
arnabnandy7
force-pushed
the
fix/shareSearchFilterDispatch
branch
2 times, most recently
from
August 22, 2026 03:13
2fb9b4f to
0fb5edb
Compare
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
arnabnandy7
force-pushed
the
fix/shareSearchFilterDispatch
branch
from
August 22, 2026 03:14
0fb5edb to
c66675b
Compare
jasperblues
approved these changes
Aug 23, 2026
jasperblues
left a comment
jasperblues
left a comment
Contributor
There was a problem hiding this comment.
Approved. Follow-up raised as #1970, not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share property-filter dispatch between vector and text search.
VectorSearch.searchWithFilterandTextSearch.searchWithFilterhelpersVectorSearchToolsandTextSearchToolsto the shared helperstopKinflation, result ordering, and truncationTesting
mvn -f embabel-agent-rag/embabel-agent-rag-core/pom.xml \ -Dtest=ToolishRagTest#TextSearchToolsTests testFixes #1960.