Consistently allow for aiModelWebClientBuilder#1590
Conversation
This commit ensures that all subclasses of OpenAiCompatibleModelFactory have a webClientBuilder: ObjectProvider<WebClient.Builder> constructor parameter, so that users can configure WebClient (e.g. for OAuth2 or custom authentication) without having to bypass autoconfiguration. Closes embabelgh-1584 Signed-off-by: Arjen Poutsma <poutsma@mac.com>
|
@alexheifetz I wasn't sure if the |
|
i think having compile dependency on spring-webflux should be OK Here is why:
|
|
@poutsma, do we care about Javadocs for public methods? |
It depends :). I do care about documentation for public, user-facing API methods, but the changes made in this PR do not fall in that category. The only new public method this PR introduces is a |
This PR ensures that all subclasses of OpenAiCompatibleModelFactory have a
webClientBuilder: ObjectProvider<WebClient.Builder>constructor parameter, so that users can configure WebClient (e.g. for OAuth2 or custom authentication) without having to bypass autoconfiguration.Closes gh-1584