Allow disabling app filter switch#856
Open
utafrali wants to merge 1 commit intoemanuele-f:masterfrom
Open
Conversation
Owner
|
Hello, thanks for the PR. This PR changes the behavior of the toggle, which is now more convenient when you need to only set one app filter but can be a problem for people having multiple app filters and that want to add a new app to it. I'm keeping this open until I define the new behavior for #281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #855
The switch always opened the selector dialog when clicked, preventing you from simply disabling the filter. Now you can turn it off without the dialog appearing.