Skip to content

fix(release): ensure start_expert works if symlinked#572

Merged
doorgan merged 1 commit intoelixir-lang:mainfrom
AlternateRT:start-expert-symlinking
Apr 14, 2026
Merged

fix(release): ensure start_expert works if symlinked#572
doorgan merged 1 commit intoelixir-lang:mainfrom
AlternateRT:start-expert-symlinking

Conversation

@AlternateRT
Copy link
Copy Markdown
Contributor

With this, it should now be possible to symlink start_expert anywhere (e.g. ~/.local/bin/expert).

@doorgan
Copy link
Copy Markdown
Collaborator

doorgan commented Apr 13, 2026

Thank you! Do we also need to update start_expert.bat for windows?

@AlternateRT
Copy link
Copy Markdown
Contributor Author

I'm not entirely sure. It would also be impossible for me to test any update to that file as I do not use windows.

But from what I gathered by looking at the .bat files that ship with ElixirLS and Elixir v1.19 (language_server.bat and elixir.bat respectively), it might not be needed; upon inspecting those files, neither contained a mechanism to resolve a symlink.

I can't say this for certain, but I think they lack that mechanism because symlinking is a less common practice in Windows-land.

Copy link
Copy Markdown
Collaborator

@doorgan doorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this for windows on a different pr if needed
Thank you! 💜

@katafrakt
Copy link
Copy Markdown
Contributor

I can test Windows at some point (I have Expert set up on one), but I agree this should not block this PR.

@doorgan doorgan merged commit c11f489 into elixir-lang:main Apr 14, 2026
37 checks passed
@AlternateRT AlternateRT deleted the start-expert-symlinking branch April 14, 2026 15:52
katafrakt pushed a commit to katafrakt/expert that referenced this pull request Apr 21, 2026
With this, it should now be possible to symlink `start_expert` anywhere
(e.g. `~/.local/bin/expert`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants