fix: handle LSP supported invalid configuration values#551
Merged
Conversation
Contributor
|
Checking the code around, I discovered that we are not, in fact, ignoring such values. This causes reset to defaults - and same happens if Here's a branch with a failing tests reproducing the issue: https://github.com/katafrakt/expert/tree/invalid-config-test |
doorgan
force-pushed
the
doorgan/invalid-configuration
branch
from
d9e0dfe to
db1038c
Compare
Collaborator
Author
|
Agh good catch, fixed! |
Contributor
|
I have tested this locally with this branch and it fixes my issue, thanks |
katafrakt
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #540
Normalized invalid values to an empty map. The LSP spec apparently supports a variety of non-object values, so in this PR we just ignore anything that is not an object/map.