fix: don't infinitely loop prompting to fetch dependencies if it fails#548
Open
fix: don't infinitely loop prompting to fetch dependencies if it fails#548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #534
I couldn't reproduce it, but from the looks of it, it's very likely it happens because the
:clean_and_fetch_depshandler unconditionally returns:ok, so the upstream code doesn't know how to properly handle a failure to fetch deps and keeps asking to fetch them again.Also to avoid spamming further and to also provide a way for the user to properly retry deps fetching in case of error(or refuse to keep trying), a new notification and handler for a "Retry" path is added