fix(engine): unify import lookup to correctly resolve local calls#547
Merged
doorgan merged 1 commit intoelixir-lang:mainfrom Apr 4, 2026
Merged
fix(engine): unify import lookup to correctly resolve local calls#547doorgan merged 1 commit intoelixir-lang:mainfrom
doorgan merged 1 commit intoelixir-lang:mainfrom
Conversation
commit-id:1367983a
doorgan
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on macro expansion indexing, I figured out that
Entity.resolveis ignoring imports, leading to wrong mfa. This causes index search to find nothing, in which case we fallback to elixirsense (this may be the reason some cases seem to work). At least function capture case did not work.